Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Updated yarn.lock hash for react-native-mock #546

Conversation

jglover
Copy link
Contributor

@jglover jglover commented Oct 21, 2017

Updates hash for react-native-mock to match expected 96bee7b072cea66f5dfa21c39b2416ca6fb6c0da.
This also causes some cascading changes in the lock file after running yarn (install) again so should be treated with caution.
Tested on Android (physical) and iOS simulator.

@jglover jglover changed the title Fix: Updated hash for react-native-mock Fix: Updated yarn.lock hash for react-native-mock Oct 21, 2017
@alejandronanez
Copy link
Member

alejandronanez commented Oct 21, 2017

What command did you run to update the yarn.lock file? Modifying directly yarn.lock is not good.

Also, welcome thanks for your first contribution!

@jouderianjr
Copy link
Member

hey @alejandronanez I think he just deleted the yarn.lock and ran yarn install again, I did that and worked in my env 😄

@alejandronanez alejandronanez merged commit d0cb8a5 into gitpoint:master Oct 21, 2017
@jglover
Copy link
Contributor Author

jglover commented Oct 22, 2017

Just to give some background, I updated the hash via yarn remove and yarn add, I believe the hash may have been wrong originally because someone updated the file manually, probably resolving a conflict gone bad?
The other changes were caused by running yarn afterwards, which I believe has caused it to add dependencies for react-native-mock whilst also making sure it has all the versions required by peer dependencies.

@andrewda
Copy link
Member

Guessing the issue was b/c I used the fork instead of the original and didn't do it through yarn. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants