Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borders are bolded a lot more #580

Closed
chinesedfan opened this issue Oct 25, 2017 · 3 comments
Closed

Borders are bolded a lot more #580

chinesedfan opened this issue Oct 25, 2017 · 3 comments
Labels
has pr styling
Projects
v1.4.0

Comments

@chinesedfan
Copy link
Member

Separated from #569.

It is due to two adjacent sections both have borders.
@chinesedfan chinesedfan added this to the Release 1.4.0 milestone Oct 25, 2017
@chinesedfan chinesedfan added this to To Do in v1.4.0 Oct 25, 2017
@machour
Copy link
Member

machour commented Oct 25, 2017

For this case, I think that we should declare a global border style and use it everywhere where needed

@machour machour mentioned this issue Nov 4, 2017
Merged
@machour machour added the has pr label Nov 4, 2017
@machour
Copy link
Member

machour commented Nov 4, 2017

@chinesedfan I think it's more due to a change in default values of react-native-elements ListItem.
I addressed the problem in #619

@machour machour moved this from To Do to Ready for review in v1.4.0 Nov 5, 2017
@chinesedfan
Copy link
Member Author

Fixed by #619.

@chinesedfan chinesedfan moved this from Ready for review to Completed in v1.4.0 Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has pr styling
Projects
No open projects
v1.4.0
Completed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@machour @chinesedfan