Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mention area component fontSize prop #602

Merged
merged 3 commits into from
Oct 29, 2017
Merged

fix: Mention area component fontSize prop #602

merged 3 commits into from
Oct 29, 2017

Conversation

alejandronanez
Copy link
Member

@alejandronanez alejandronanez commented Oct 29, 2017 •
edited
Loading

Question Response
Version? v1.4.0
Devices tested? iPhone 7 simulator
Bug fix? yes
New feature? no
Includes tests? no
All Tests pass? yes
Related ticket?

Description

App was crashing when you mention someone in an issue. Updating fontsize style prop into font-size fixes the issue.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.192% when pulling 030a67d on mention-area-fix into 0c0a163 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.192% when pulling 030a67d on mention-area-fix into 0c0a163 on master.

@alejandronanez alejandronanez merged commit c3e019a into master Oct 29, 2017
@alejandronanez alejandronanez deleted the mention-area-fix branch October 29, 2017 02:09
@machour machour mentioned this pull request Oct 29, 2017
Closed
@machour machour added this to Completed in v1.4.0 Nov 5, 2017
@machour machour removed this from Completed in v1.4.0 Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewda andrewda andrewda approved these changes

@housseindjirdeh housseindjirdeh Awaiting requested review from housseindjirdeh

@machour machour Awaiting requested review from machour

@chinesedfan chinesedfan Awaiting requested review from chinesedfan

Assignees
No one assigned
Labels
🐛 bug crash high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alejandronanez @coveralls @andrewda