fix(search-bar): Compile Ionicons for Android #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: If you want to test this PR, make sure to run: react-native unlink react-native-vector-icons
yarn clean && yarn clean:android
yarn run link # make sure you see react-native-vector-icons being linked again
yarn start:android |
chinesedfan
approved these changes
Nov 6, 2017
There was a problem hiding this comment.
@machour We have two kinds of search bar. react-native-search-bar for iOS, and react-native-material-design-searchbar for Android. Thanks for your fix!
|
@chinesedfan oops, overlooked that. It makes a lot of sense then, thank you for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Description
Added Ionicons.ttf compilation back in
build.gradleas it is needed byreact-native-material-design-searchbar./cc @dyesseyumba for info
/cc @chinesedfan I'm wondering how this was still working fine for iOS. Did we really remove unwanted TTF there? 🤔
Fix #630