Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new auth methods #732

Closed
ShalokShalom opened this issue Feb 15, 2018 · 15 comments
Closed

new auth methods #732

ShalokShalom opened this issue Feb 15, 2018 · 15 comments

Comments

@ShalokShalom
Copy link

See this whole thread and especially that linked convo:

#674 (comment)

@ShalokShalom ShalokShalom changed the title new auth mothods new auth methods Feb 15, 2018
@housseindjirdeh
Copy link
Member

Thanks so much for logging this :)

Quite a few folks are experiencing this - definitely something we need to prioritize for our next release

@ShalokShalom
Copy link
Author

And it happens in all the Github clients I tried yet.
So all which are available for 4.3
Here is another discussion ongoing:
slapperwan/gh4a#818
Thanks a lot for addressing this as high priority. :)

@ShalokShalom
Copy link
Author

Ok, same news: Its in the auth app itself.

This issue happens to me on all different implementations.
And the auth on pages who offer both, Twitter and Github, works for Twitter and not for Github.

@ShalokShalom
Copy link
Author

img_20180225_081519

@ShalokShalom
Copy link
Author

Octodroid added password/username login back: slapperwan/gh4a@270e952

@ShalokShalom
Copy link
Author

Is this also a solution for this project?

@ShalokShalom
Copy link
Author

Is there any news on this high priority issue? 🙂

@machour
Copy link
Member

machour commented Mar 21, 2018

Hi @ShalokShalom, unfortunately all maintainers have been quiet busy lately.
Do you feel like tackling this one?

@ShalokShalom
Copy link
Author

I am currently unable to do any JavaScript

@machour
Copy link
Member

machour commented Mar 22, 2018

@ShalokShalom could you remove the app and install https://idk.tn/gitpoint-test.apk ?

After clicking "Sign in" you should see a really ugly "Can't sign in" button that will open the GitHub oAuth URL in your browser. Tell me if that works for you 🙏

@ShalokShalom
Copy link
Author

Nope. Same out-greyed button.

@machour
Copy link
Member

machour commented Mar 22, 2018

In your Android browser this time? :/

@ShalokShalom
Copy link
Author

In my Blackberry browser, which is pretty outdated.
It works in Firefox :D

@machour
Copy link
Member

machour commented Mar 22, 2018

🍾 🍾 🍾 🍾 🍾 🍾 🍾
Will come up with a nicer UI and hopefully release this soon
Thank you for bearing with us :D

@ShalokShalom
Copy link
Author

Sure sure

Thanks for dealing with me 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants