Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can gitdb submodule be removed? #268

Closed
garious opened this issue Mar 5, 2015 · 7 comments
Closed

Can gitdb submodule be removed? #268

garious opened this issue Mar 5, 2015 · 7 comments

Comments

@garious
Copy link

garious commented Mar 5, 2015

I see gitdb in the requirements.txt. Can the submodule be removed?

@Byron
Copy link
Member

Byron commented Mar 6, 2015

It seems you are stating one solution to a problem you are having. Would you share information about that problem with me ?
Thanks

@garious
Copy link
Author

garious commented Mar 6, 2015

The problem is confusion. Is the submodule still in use or a legacy solution that predates pip?

@Byron
Copy link
Member

Byron commented Mar 6, 2015

No, it's not related to pip at all, but to developing git-python. The submodules are dependencies that you can just checkout, and run all the tests of git-python without installing any of these. That's what these are there for. pip doesn't see the 'ext' folder.
The given argument wouldn't be enough to make me remove these submodules, but maybe the explanation helps to disperse the confusion a little ?

@garious
Copy link
Author

garious commented Mar 6, 2015

I think that a cleaner way to develop in that style would be to create a super-project (say gitpython-dev) that adds both GitPython and GitDB as submodules. Another strategy might be to scrap the submodules and in the readme, suggest adding a -e line with a Github URL to requirements.txt.

@Byron
Copy link
Member

Byron commented Mar 7, 2015

You have been motivated enough to file an issue about this topic, but I still don't understand what this confusion is all about. The submodule 'gitdb' doesn't get in your way at all, it's just an empty folder after ordinary clone, and trying to run tests yields ImportError: 'gitdb' could not be found in your PYTHONPATH.
Those who follow the instruction in the README will get the submodule checkout and thus are fine. Others can use pip to get dependencies differently and be fine too.
Maybe some sort of info.txt in git/ext would help to get the part with the confusion under control. What do you think ?

@garious
Copy link
Author

garious commented Mar 7, 2015

I'm just trying to understand why this Python repo is doing things differently than the others. Thanks for the replies. You can close this issue.

@Byron
Copy link
Member

Byron commented Mar 7, 2015

I think the answer to that one is that gitpython was my first bigger open source python project, and from day one I struggled with the standard tools python provided, namely setup tools. Using plain git to solve certain issues was easier for me than fumbling around with what might have been standard. The remnants of this ignorance are here to this day, and shall serve as signpost for others on how not to do it :).

@Byron Byron closed this as completed Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants