Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ports in GrafanaDBSecurityGroupIngress #3

Open
giusedroid opened this issue Jan 16, 2019 · 0 comments
Open

Import ports in GrafanaDBSecurityGroupIngress #3

giusedroid opened this issue Jan 16, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@giusedroid
Copy link
Owner

Import ports in GrafanaDBSecurityGroupIngress

As a developer I want to make cloudformation templates as general as possible, so that they can be reusable.

For this issue, the value of ports for a the security group GrafanaDBSecurityGroupIngress in cloudformation/20-grafana-ecs-service.yml has been hardcoded to 3306 for both FromPort and ToPort.

Furthermore, in cloudformation/10-aurora-backend.yml the port of the service is exported with the name ${Environment}-grafana-service-aurora-backend-port.

Reusability of this template could improve by either importing the port or referencing it as a parameter and adding the port to the env variables.

Acceptance Criteria

  • the value of the port is not hardcoded
  • the value of the port is either imported via Fn::ImportValue or referenced as a CloudFormation parameter.
  • if referenced as a parameter, the Makefile must provide the value of the port to the template.
@giusedroid giusedroid added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant