Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site crashes with PHP error when trying to save new site #96

Open
lkthfx opened this issue Mar 14, 2024 · 3 comments
Open

Site crashes with PHP error when trying to save new site #96

lkthfx opened this issue Mar 14, 2024 · 3 comments

Comments

@lkthfx
Copy link

lkthfx commented Mar 14, 2024

Steps to reproduce:

  1. go to admin page -> sites list : /index.php?module=settings/sites
  2. press "add site" button
  3. fill forms
  4. press "save site"
    Result:
    image

Fix:
in /admin/controller/settings/site.php
line 149 $site['id'] = $site_id;
line 152 list($site, $settings, $site_id, $data) = Event :: trigger(__CLASS__,__FUNCTION__, $site, $settings, $site_id, $data);

@givanz
Copy link
Owner

givanz commented Mar 14, 2024

Thanks for the bug report, I fixed the warning b529366

@Twilight-Computer
Copy link

Line 52 should read $setting not $settings as shown above - just in case someone copies that line :-)

@givanz
Copy link
Owner

givanz commented Mar 20, 2024

Thanks for pointing out, I fixed wrong event parameters 3a2cfc6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants