Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended functions #11

Closed
dieselpilot opened this issue Aug 8, 2018 · 4 comments
Closed

Extended functions #11

dieselpilot opened this issue Aug 8, 2018 · 4 comments

Comments

@dieselpilot
Copy link

Hey Givan,

Love this project - really great tool and excellent idea! I'm not technical so forgive the questions but looking for some basic info on the following:

  1. In the demo, I am unable to execute JS functions when in preview mode (by copy and paste into code editor). Is this possible?

  2. Can pages be linked together to create click through from buttons?

  3. Do you have example of script which will allow pages to be saved to server?

I have lots more questions, but will leave it here for now. Thanks for the help!

@givanz
Copy link
Owner

givanz commented Aug 24, 2018

Hi

Thank you.

1 I added a checkbox "Run code on edit" for running js code when editing in the last commit.

2 You mean edit more pages and link them together to create a complete website? If the pages are in the same folder then when editing the link you can set as the url only the filename (ex mypage.html)

Probably what you want is a select input to select the available pages in file manager as the url, you can do this by adding a new input in inputs.js and then change the input type for links in bootstrap4.js

3 Please see this #12 for a basic solution

@lankaapura
Copy link

@givanz thanks for the great library.

I'm using this library to build an HTML designer which need support for dynamic HTML(angularJS to be specific). I had to do a lot of framework code changes to get an initial prototype working because all dynamically generated HTML get synced to code editor making exported HTML useless.

Do you have any plans to implement it in the future? I'm trying to implement this as a plugin so I can send a PR but with the current level of code changes, I don't think it will be possible. Any advice on implementing it as a plugin?

@dieselpilot
Copy link
Author

@givanz Thanks so much for your response and for the changes.

I have a couple more questions:

  1. Run JS on clicking edit check box: Sorry to ask what may be the obvious but you're saying that in the edit mode I will be able to run JS based on the last commit. So the workflow would be: Add JS element in edit mode > save > JS element can now run in edit mode? I assume this would also work in preview mode too?
    image

  2. Incorporate walkthrough / tour builder: It would be great to be able to build a tour to walk a user through a full site created in your tool. I have been looking at this tool here http://linkedin.github.io/hopscotch// and would like to try and include this into the tool so upon clicking preview it can create an interactive walk through. Any advice on this would be great.

Once again, fantastic tool and thanks for taking the time with my questions.

@givanz
Copy link
Owner

givanz commented Mar 10, 2019

Hi

Preview does not restart javascript on page or reload the page, it only hides panels.

I guess hopscotch can be added on any page including the editor easily by following the hopscotch documentation, I don't think there is anything specific or any incompatibility with the editor.

@givanz givanz closed this as completed Mar 10, 2019
lepe pushed a commit to lepe/VvvebJs that referenced this issue Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants