Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video and Maps iFrame #2

Closed
oleteacher opened this issue Mar 30, 2018 · 3 comments
Closed

Video and Maps iFrame #2

oleteacher opened this issue Mar 30, 2018 · 3 comments

Comments

@oleteacher
Copy link

First, great job on VvvebJa!

When adding videos (or maps) they are inserted with values 100% width and 100% height. The 100% height does not work as iframes do not scale like images. You end up with very wide video with tiny height.

Maybe this stackoverflow issue can better explain what I mean:

https://stackoverflow.com/questions/38270661/displaying-a-youtube-video-with-iframe-full-width-of-page

Not sure of best approach to solve but since user cannot edit source or change layout, videos are not working correctly.

Also, be really nice feature to allow editing of source code:)

Thanks for sharing your work!

@givanz
Copy link
Owner

givanz commented Apr 2, 2018

Thanks for the suggestion, I added width and height inputs for both widget components and also code editor support.

@oleteacher
Copy link
Author

Great!

@oleteacher
Copy link
Author

Very nice addition for the videos!

Only issue I see is the videos are no longer responsive without extra css. No big issue since you added the code editor though:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants