Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 11 Issue #7

Closed
gauravkamath opened this issue Jun 25, 2018 · 7 comments
Closed

IE 11 Issue #7

gauravkamath opened this issue Jun 25, 2018 · 7 comments

Comments

@gauravkamath
Copy link

Hi,

Good day to you 馃憤

I am not able to run this project on IE 11. I tried fixing few of the code errors but the drag and drop still fails. When i drag & drop a component, there is no change in the code editor neither is the component rendered on iFrame. Do you have any idea about what the problem could be?

@givanz
Copy link
Owner

givanz commented Jun 25, 2018

Hi

The issue is related to appending elements to iframe.
In ie11 console I see 'Unable to get property "createDocumentFragment" of undefined or null reference' in builder.js line 665/668 this is not transparently handled by jQuery append/prepend etc so it will probably require a new append function that has hacks for ie, unfortunately I'm unable to find any reference to what hack ie11 needs to achieve this.

@gauravkamath
Copy link
Author

Thank you Givanz. Please update me if you do find a hack for IE 11.
Any help is much appreciated. 馃挴

@gauravkamath
Copy link
Author

Hi Givanz,

I could make the drag & drop work in IE. The issue mentioned by you was being caused because of the wrong parent element. Somehow parent = self.highlightEl; did not work and as a result parent.append would break. I tried using $(self.highlightEl).append(self.dragElement); directly and drag & drop now works.

The code editor is still not working and i am working on finding a solution for that. will keep you updated if i find any solution for it.

@givanz
Copy link
Owner

givanz commented Jul 3, 2018

Thanks for the fix, I just tested and it works even if not as smooth as on chrome/firefox but this is probably caused by slower js/render engine.

I tested code editor on ie11 win7 virtual box and it works, what problems do you have with the editor and what platform are you using?

@givanz givanz closed this as completed Jul 3, 2018
@givanz givanz reopened this Jul 3, 2018
@gauravkamath
Copy link
Author

gauravkamath commented Jul 4, 2018

Well Property window changes doesn't reflect anything in the code editor.

I am trying it on IE 11 in windows 10.

@givanz
Copy link
Owner

givanz commented Jul 5, 2018

I fixed property change and also pushed the changes for ie11.

@gauravkamath
Copy link
Author

Thank you so much Givanz 馃挴 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants