Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ship tests and allow using StateLogManager in migrations #95

Merged
merged 1 commit into from Jan 14, 2022
Merged

Do not ship tests and allow using StateLogManager in migrations #95

merged 1 commit into from Jan 14, 2022

Conversation

imomaliev
Copy link
Contributor

Fixes #94

@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #95 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #95      +/-   ##
=========================================
+ Coverage   96.25%   96.3%   +0.04%     
=========================================
  Files          24      25       +1     
  Lines         481     487       +6     
=========================================
+ Hits          463     469       +6     
  Misses         18      18
Impacted Files Coverage Δ
...ango_fsm_log/migrations/0004_auto_20190131_0341.py 100% <100%> (ø)
django_fsm_log/conf.py 100% <100%> (ø) ⬆️
django_fsm_log/managers.py 97.29% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355cb22...b314fad. Read the comment docs.

@imomaliev imomaliev changed the title Do not ship tests and allow using StateLogMananger in migrations Do not ship tests and allow using StateLogManager in migrations Jan 31, 2019
@MRigal MRigal mentioned this pull request Oct 20, 2021
@ticosax ticosax merged commit f9a4c04 into jazzband:master Jan 14, 2022
@ticosax
Copy link
Member

ticosax commented Jan 14, 2022

thanks, and sorry it took so long.

@MRigal
Copy link
Member

MRigal commented Jan 14, 2022

Glad to see that you are doing a real update on the package @ticosax ! Thanks for this. You might still consider transferring the package to jazzband for easier maintenance in the future, see jazzband/help#248

@ticosax
Copy link
Member

ticosax commented Jan 14, 2022

I'm thinking about it, just I don't feel it's my decision to make, despite I have admin role (I didn't knew).
@tysonclugg , as a former maintainer of this project, do you have an opinion about transferring this project onto jazzband organization ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow manager to be used in migrations
5 participants