Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver test needs --ip defined not --ip-address #11

Closed
Limb opened this issue Jul 31, 2020 · 2 comments
Closed

driver test needs --ip defined not --ip-address #11

Limb opened this issue Jul 31, 2020 · 2 comments

Comments

@Limb
Copy link

Limb commented Jul 31, 2020

The README.md states "Note: If necessary you can specify the GW1000 IP address and port using the --ip-address and --port command line options. Refer to the GW1000 driver help using --help for further information."

However the driver actually expects --ip to be defined, and throws an error if --ip-address is used. (The --help command informs you to use --ip)

I would suggest changing the --ip parameter to --ip_address to be consistent with the weewx configuration file, which uses ip_address.

@gjr80
Copy link
Owner

gjr80 commented Aug 1, 2020

Thanks for the feedback, it was a deliberate decision to use --ip but I can see it could be confusing. Will fix in b10.

@gjr80
Copy link
Owner

gjr80 commented Aug 1, 2020

Commit 8898725 refers

@gjr80 gjr80 closed this as completed Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants