Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the render option called unsafe_ and not unsafe? #219

Closed
DannyBen opened this issue Jan 17, 2023 · 4 comments
Closed

Why is the render option called unsafe_ and not unsafe? #219

DannyBen opened this issue Jan 17, 2023 · 4 comments

Comments

@DannyBen
Copy link
Contributor

DannyBen commented Jan 17, 2023

Is this designed to warn (or shame) the user for using it?
Can this be renamed to just unsafe?

render: {
unsafe_: true,
},

@gjtorikian
Copy link
Owner

Warn is more likely. The option name was taken straight from comrak: https://github.com/kivikakk/comrak#security

@DannyBen
Copy link
Contributor Author

Two wrongs don't make a right. This is not Ruby like, and the word "unsafe" is warning enough.

@gjtorikian
Copy link
Owner

Ok.

Repository owner locked as resolved and limited conversation to collaborators Jan 17, 2023
@kivikakk
Copy link
Collaborator

unsafe is a keyword in Rust.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants