Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the TABLE_PREFER_STYLE_ATTRIBUTES render option #66

Merged
merged 3 commits into from Feb 21, 2018
Merged

Support the TABLE_PREFER_STYLE_ATTRIBUTES render option #66

merged 3 commits into from Feb 21, 2018

Conversation

gfx
Copy link
Contributor

@gfx gfx commented Feb 20, 2018 •
edited

@gjtorikian
Copy link
Owner

If you can throw in a Ruby test you're golden! A simple string match showing that the attribute name changes should suffice. Thanks!

@gfx
Copy link
Contributor Author

gfx commented Feb 21, 2018

Sure! Added tests in 5d8d953.

@kivikakk
Copy link
Collaborator

Excellent! Thank you.

@kivikakk kivikakk merged commit a8a7f6b into gjtorikian:master Feb 21, 2018
@kivikakk
Copy link
Collaborator

This is now released in 0.17.8.

@gfx
Copy link
Contributor Author

gfx commented Feb 21, 2018

Thanks! 👏

@gfx gfx deleted the table_prefer_style_attributes branch February 21, 2018 03:42
@gfx gfx mentioned this pull request Feb 21, 2018
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gfx @gjtorikian @kivikakk