Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open source, transferring repo ownership #12

Closed
jch opened this issue Nov 4, 2012 · 8 comments
Closed

Open source, transferring repo ownership #12

jch opened this issue Nov 4, 2012 · 8 comments

Comments

@jch
Copy link
Contributor

jch commented Nov 4, 2012

I think this repo is ready for 🚢ing. #6 extracted this project from .com, and removed GitHub specific references in the gem. Here's a list of remaining things I'd like to do before I share the ❤️ with the world:

  • update the readme
  • write a blog post with some examples
  • add travis
  • transfer ownership to jch (per @rtomayko, having a maintainer rather than putting it under the org)

Is there anything I'm missing?

@jbarnette
Copy link
Contributor

https://github.com/github/html-pipeline/blob/master/script/bootstrap#L4isn't
good. It should just bail with a friendly message if bundle isn't
in the path.

I'm not sure I understand the point of --standalone either.

The bundler dep in
https://github.com/github/html-pipeline/blob/master/Gemfile#L7 isn't
necessary. The :development, :test group for rake is also not really
needed: Just :development is fine.

Seems like the copyright in LICENSE should be for GitHub, Inc. and Jerry
Cheung.

The README needs an example of a require.

The gemspec isn't named correctly. It should be html-pipeline, not
github-html.

The author, author email, and homepage in the gemspec need to be fixed. The
content discovery for the gemspec is also a bit suspect: See
https://github.com/github/egress/blob/master/egress.gemspec for a bit more
straightforward of an approach.

I'm happy to do PRs for this stuff, but since you asked. :)

On Sun, Nov 4, 2012 at 11:45 AM, Jerry Cheung notifications@github.comwrote:

I think this repo is ready for [image: 🚢]ing. #6https://github.com/github/html-pipeline/issues/6extracted this project from .com, and removed GitHub specific references in
the gem. Here's a list of remaining things I'd like to do before I share
the [image: ❤️] with the world:

  • update the readme
  • write a blog post with some examples
  • add travis
  • transfer ownership to jch (per @rtomaykohttps://github.com/rtomayko,
    having a maintainer rather than putting it under the org)

Is there anything I'm missing?


Reply to this email directly or view it on GitHubhttps://github.com/github/html-pipeline/issues/12.

@jch
Copy link
Contributor Author

jch commented Nov 4, 2012

@jbarnette I'm thinking of removing script/bootstrap entirely. It's a GitHub specific convention and not necessary for the open source gem. Thoughts?

@jbarnette
Copy link
Contributor

I don't mind having script/boostrap exist, I think isolated deps are a good
thing for gem development. It's definitely not vital to keep around if it's
bothering you, though.

On Sun, Nov 4, 2012 at 3:40 PM, Jerry Cheung notifications@github.comwrote:

@jbarnette https://github.com/jbarnette I'm thinking of removing
script/bootstrap entirely. It's a GitHub specific convention and not
necessary for the open source gem. Thoughts?


Reply to this email directly or view it on GitHubhttps://github.com/github/html-pipeline/issues/12#issuecomment-10057324.

@jbarnette
Copy link
Contributor

Weird, our email stuff collapsed a bunch of my other comments in that first bit. Might want to expand that and take a look if you didn't already.

@jch
Copy link
Contributor Author

jch commented Nov 4, 2012

@jbarnette strange indeed. Awesome suggestions for cleanup, I'll add those as well. Next time I'll definitely rope you into some slave gem chores ;)

@derekgr
Copy link

derekgr commented Nov 5, 2012

Minor, but noticed the contributors list in README.md is missing mailto:'s for the links, so they get formatted like:

https://github.com/jch/html-pipeline/aman@tmm1.net

@tmm1
Copy link
Contributor

tmm1 commented Nov 5, 2012

I also noticed a link to the private repo github/camo instead of atmos/camo

@jch
Copy link
Contributor Author

jch commented Nov 6, 2012

Thanks for the input all! Closing this now.

@jch jch closed this as completed Nov 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants