Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to the email reply filter #82

Closed
r38y opened this issue Sep 9, 2013 · 2 comments
Closed

Tweaks to the email reply filter #82

r38y opened this issue Sep 9, 2013 · 2 comments

Comments

@r38y
Copy link

r38y commented Sep 9, 2013

Am I correct in thinking this is used to parse the replies on GitHub? If so, what do you think about adding a way to strip the garbage from this:

remove_redundant_data_tidy_up_the_code_indentation_and_add_a_new_menu_i _by_dylanbarwick__pull_request_125__bauerpubtwinit_20130909_113910

I'm happy to do it but I wanted to make sure this filter was the correct place to do it.

I think the non-code solution is for that dude to delete the garbage from his email but that is sort of "you're holding it wrong".

@jch
Copy link
Contributor

jch commented Sep 9, 2013

Yep, it's one of the filters used to parse replies from GitHub. There's been some discussion and prototypes about stripping out signatures from replies, but when we tried it internally, some legitimate content would be stripped in some cases. We erred on the side of garbage sometimes rather than missing content. Hope that clears things up. 🍻

@jch jch closed this as completed Sep 9, 2013
@r38y
Copy link
Author

r38y commented Sep 9, 2013

Yeah, I was looking to get rid of those extra headers but I guess it would be impossible to tell if they meant to add that in there or if it was from their email client. I guess I'll have to tell him he is holding it wrong. Or try to ignore it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants