Internally linking to <valid URL> which does not exist

[daenney]

I'm getting a whole bunch of these:

  *  internally linking to https://daenney.github.io, which does not exist (line 61)
     <a class="back-button icon-arrow-left" href="https://daenney.github.io">Home</a>

As far as I can see, there's nothing wrong with both the <a> tag or the href, and it very much does exist.

I run HTMLProofer with {:internal_domains => ["daenney.github.io"]}. Removing this makes all the errors go away. This is rather strange to me, I don't really understand why that would be the case. It seems I'm misunderstanding what An array of Strings containing domains that will be treated as internal urls. means from the docs, but I'm not quite sure how else to interpret it?

[gjtorikian]

Some people like to write their URLs out, like this: http://www.example.com/link_to_folder.html

But sometimes, the domain is autogenerated for you. This comes up in situations where Jekyll, for example, is being used to prepend links with a base URL: {{ site.base_url }}/link_to_folder.html. (#489 and #349 might be good resources for more info.)

In your case, I would bet that changing the link to https://daenney.github.io/ (note the final slash) would work, given that all internal_domains does is substitute out the domain (regardless of HTTP/HTTPS protocol). If that fixes it then I ought to change the code or the error message here.

Although if you're generating the link yourself, and don't need internal_domains, I would usually just recommend rewriting the link itself: <a class="back-button icon-arrow-left" href="/">Home</a> and removing the option.

[daenney]

So it turns out the trailing slash doesn't matter, the fact hat I had omitted the protocol does. Using internal_domains => ["daenney.github.io"] or daenney.github.io/ results in the same set of errors. Using https://daenney.github.io, with or without a trailing slash, clears the error. I would've expected the protocol to not matter, so this seems like a bug to me.

As with the two issues you mentioned, this content is generated by Jekyll so I get the full/absolute URLs, domain and everything.

In case it's relevant:

• Ruby: 2.6.5
• html-proofer: 3.13.0

[DaveSkender]

Strangely "/" does not appear to be better. I'm getting this:

  *  internally linking to /, which does not exist (line N)
     <a href="/">...</a>

Ref: https://github.com/DaveSkender/Stock.Indicators/runs/4281193384

[gjtorikian]

You'll have to use the assume-extension option: https://github.com/gjtorikian/html-proofer#using-with-jekyll

[gjtorikian]

(Feel free to reopen if that didn't fix it!)