Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links without html suffix claimed to be broken #654

Closed
matkoniecz opened this issue Sep 19, 2021 · 2 comments
Closed

links without html suffix claimed to be broken #654

matkoniecz opened this issue Sep 19, 2021 · 2 comments

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Sep 19, 2021

<a href="page_linked_without_using_html_prefix">page_linked_without_using_html_prefix</a> where page_linked_without_using_html_prefix.html exists is claimed to be broken

To reproduce

git clone https://github.com/matkoniecz/dead_links_testing_site
cd dead_links_testing_site/
htmlproofer index.html 
Running ["ScriptCheck", "LinkCheck", "ImageCheck"] on index.html on *.html... 


Checking 2 external links...
Ran on 1 file!


- index.html
  *  image test png with space.png does not have an alt attribute (line 0)
  *  image test_png_with_zażółć_gęślą_jaźń.png does not have an alt attribute (line 0)
  *  image test_png_without_space.png does not have an alt attribute (line 0)
  *  internally linking to page_linked_without_using_html_prefix, which does not exist (line 0)
     <a href="page_linked_without_using_html_prefix">page_linked_without_using_html_prefix</a>

HTML-Proofer found 4 failures!

Note that page_linked_without_using_html_prefix link actually works when deployed - for example at https://matkoniecz.github.io/dead_links_testing_site/

Is it supposed to be not working and github pages is using some weird magic? Note, I deployed it also locally ( for example using https://github.com/matkoniecz/website-checklist/blob/master/validators.md#checking-local-html-files method) and it also worked.

@gjtorikian
Copy link
Owner

See if it works with the --assume-extension CLI option: https://github.com/gjtorikian/html-proofer#using-with-jekyll

@matkoniecz
Copy link
Contributor Author

Yes, it worked! Thanks, I missed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants