Carthage support #22
Closed
Carthage support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected: 'Available validators' link in Contents section.
Readme: fixed: 'Available validators' link
- [Tests] updated Quick and Nimble - [Version] changed the version 7.0.0.
Removes use of characters
…tion problems with new build system
Fix Xcode new build system compilation problem
Added isURL validator
- added more test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is another approach to providing Carthage support. In my previous pull request, I had committed the Pods directory so that the files included in the main project are within the source. But as per your suggestion that Pods directory should not be committed, I had to make some changes.
-> Removed Quick and Nimble dependencies using Cocoapods
-> Added the dependencies using Carthage. This way, no extra file is included in the main project. For testing, the users will have to do a
carthage bootstrap.-> Shared the framework schema
-> No other change has been made to the code.
Let me know if this is okay.