Add typescript #71
Merged
Add typescript #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
reviewed
Sep 8, 2022
|
The indentation issue was only about my formatter 馃槄 |
gkjohnson
reviewed
Sep 9, 2022
|
Excellent, thank you again! This is a great addition. If you're still interested in digging into the code a bit more adding some documentation for new classes #72 would be another good place to dive in - I can help provide insight on what some of these different classes do and why, as well. Of course no pressure, though, I appreciate the help! |
This was referenced Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #65
For example, the Constants type, the HalfEdgeHelper class, I added the code but it is commented because I'm not sure which is the correct type of the halfEdge parameter.
Maybe it's all a mess 馃槄, please tell me what you think.