Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check maxNodeTris after split #55

Closed
gkjohnson opened this issue Dec 24, 2018 · 2 comments
Closed

Check maxNodeTris after split #55

gkjohnson opened this issue Dec 24, 2018 · 2 comments

Comments

@gkjohnson
Copy link
Owner

The geometry in the benchmark with the default options winds up having the following min and max triangle counts:

tris: { min: 1, max: 76 }

despite the maxNodeTris option being set to 10. This could be solved by checking to make sure that both children counts will be above the tris threshold before splitting the nodes into separate children.

@mqp
Copy link
Contributor

mqp commented Dec 25, 2018

Nice catch, that seems right.

@gkjohnson
Copy link
Owner Author

As discussed here I think this is just an artifact of a naive split strategy and not something that should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants