New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BVH Workers: sometimes the onProgress value is > 1 or never reaches 1 #653

Closed

gkjohnson opened this issue Mar 31, 2024 · 0 comments

Labels

bug

Milestone

Owner

gkjohnson commented Mar 31, 2024 •

edited

Loading

Possibly because the final value is over or slightly off of 1.0 due to error? But unclear where it's coming from exactly.

if ( currTime - prevTime >= 10 || progress === 1.0 ) {

It's possible we should just dispatch the 1.0 value after completion to ensure it gets fired.

gkjohnson added the bug label

gkjohnson added this to the v0.7.4 milestone

gkjohnson closed this as completed in

546c0bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment