Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expressions: Simplify expression parsing, pass variables into "expr-eval" #58

Open
gkjohnson opened this issue Apr 23, 2021 · 0 comments
Open

Expressions: Simplify expression parsing, pass variables into "expr-eval" #58

gkjohnson opened this issue Apr 23, 2021 · 0 comments
Labels
help wanted Extra attention is needed
Milestone
v0.X.X

Comments

@gkjohnson
Copy link
Owner

gkjohnson commented Apr 23, 2021 •
edited
Loading

Expr-eval's parse function supports taking variables. Instead of replacing variables ahead of time we should pass the table of variables into the parse function.

Related to #57, #49
@gkjohnson gkjohnson added this to the Feature Complete milestone Apr 23, 2021
@gkjohnson gkjohnson added the help wanted Extra attention is needed label Apr 23, 2021
@gkjohnson gkjohnson modified the milestones: Feature Complete, v0.3.3, v0.3.4 Aug 6, 2021
@gkjohnson gkjohnson modified the milestones: v0.3.4, v0.3.5 Dec 9, 2021
@gkjohnson gkjohnson modified the milestones: v0.3.5, v0.3.7, v0.X.X Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
v0.X.X
Development

No branches or pull requests
1 participant
@gkjohnson