Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

being able to attach multiple images #84

Open
lenntt opened this issue Jun 13, 2017 · 5 comments
Open

being able to attach multiple images #84

lenntt opened this issue Jun 13, 2017 · 5 comments

Comments

@lenntt
Copy link

lenntt commented Jun 13, 2017

I've a test that does an image comparison and would like to have the reference, actual and diff image all in the html report.
but as long as there is a single step.image, I can't have them all in the same view.

Simple way to reproduce:

driver.takeScreenshot().then(function (buffer) {
    return scenario.attach(new Buffer(buffer, 'base64'), 'image/png');
    return scenario.attach(new Buffer(buffer, 'base64'), 'image/png'); // or even better: another buffer
}

Expected result:
2 (similar) images in the report

Current result:
1 image in the report

@gkushang
Copy link
Owner

@lenntt

There is an open PR for this feature. We will work on it on releasing soon.

Thanks!

@AltarBeastiful
Copy link

With this we could have a screenshot for each step of the test, wether they pass or fail. This would be useful when debugging failed steps. It's sometimes pretty useful to see screenshots for all the steps following an error.

If possible I'd like to mimic the "Inline screenshots" feature of protractor-beautiful-reporter :

image

@rkrisztian
Copy link

@AltarBeastiful, it doesn't seem like you're talking about the same thing, but check out cucumber/cucumber-js#997 (comment) to see how I do it.

@krarpitgupta
Copy link

@gkushang Are we planning to implement it, I have similar requirement where need to attach multiple screenshots to a cucumber steps ?

@david-vankampen
Copy link

@lenntt

There is an open PR for this feature. We will work on it on releasing soon.

Thanks!

@gkushang I know its been several years, but is this feature still possible to merge? Being able to attach multiple images to a single step would be very helpful. Right now it appears that while it loops on the embeddings attribute of each step, step.image is a singular item, so it will only keep the last image, whereas if step.image was an array, it could keep multiple. Same for other attachment types (text, logs, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants