Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firenvim not loading on latest Firefox nightly #233

Closed
ahal opened this issue Nov 15, 2019 · 4 comments · Fixed by #252
Closed

Firenvim not loading on latest Firefox nightly #233

ahal opened this issue Nov 15, 2019 · 4 comments · Fixed by #252

Comments

@ahal
Copy link

ahal commented Nov 15, 2019

  • OS Version: Linux (Fedora 31)
  • Browser Version: Firefox Nightly 72.0a1 (2019-11-15)
  • Firenvim extension: 0.1.13
  • What I tried to do: Click a textarea
  • What happened: Firenvim fails to load (white box flashes quickly, then textarea loses focus). Upon double clicking, can edit text area normally (no firenvim).

Content console contains:

Firefox can’t establish a connection to the server at ws://127.0.0.1:37195/585407150. Neovim.ts:17:19
Port disconnected for element #content-input. Neovim.ts:23:16

Browser console contains:

Promise resolved after context unloaded        nvimui.js:6148
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIInterfaceRequestor.getInterface] 3 network-response-listener.js:84
Promise resolved after context unloaded    nvimui.js:6148

I had actually just installed Firenvim today, and it was working great. Then updated to today's nightly and it stopped working. I also work at Mozilla so if this is an issue on Firefox's end, I can help raise it.

@glacambre
Copy link
Owner

glacambre commented Nov 15, 2019

Thanks for reporting this. The problem is that the Origin key of the websocket header isn't present so the neovim process cannot verify that the websocket request has been made from the firenvim webextension and not another extension/website.
I consider this a firefox bug and opened https://bugzilla.mozilla.org/show_bug.cgi?id=1596889. Let's hope it'll get fixed faster than the other bugs I reported :).

@ahal
Copy link
Author

ahal commented Nov 15, 2019

Unfortunately it looks like it may have been intentionally removed to help prevent fingerprinting. We'll see what Tom says, but this might end up needing an alternative workaround.

@glacambre
Copy link
Owner

Discussion now happening in https://bugzilla.mozilla.org/show_bug.cgi?id=1592721 .

@ahal
Copy link
Author

ahal commented Nov 22, 2019

Just noting the change that caused this failure was backed out, so Firenvim is temporarily working on Nightly again (until it re-lands).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants