Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing the user token to setAuthCookies directly (don't require an Authorization header) #233

Closed
Tracked by #265
kmjennison opened this issue Jul 16, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kmjennison
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, calling setAuthCookies during login requires the Authorization header value to be set to the Firebase ID token. This is limiting. Some people may need to define a custom tokenChangedHandler and pass the token by other means.

Describe the solution you'd like and how you'd implement it
Allow setAuthCookies to take a third optional settings parameter, { token: 'token-here' }. If token is provided, use it; otherwise use the Authorization header value; otherwise throw an error.

Is this a breaking change?
No.

Describe alternatives you've considered
None.

@kmjennison kmjennison added enhancement New feature or request help wanted Extra attention is needed labels Jul 16, 2021
@kmjennison kmjennison changed the title Allow passing the user token to setAuthCookies without using the Authorization headre Allow passing the user token to setAuthCookies without using the Authorization header Jul 16, 2021
@kmjennison kmjennison changed the title Allow passing the user token to setAuthCookies without using the Authorization header Allow passing the user token to setAuthCookies directly (don't require an Authorization header) Jul 16, 2021
This was referenced Aug 7, 2021
@kmjennison
Copy link
Contributor Author

Completed in #520.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant