Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should isEditable() be iterative instead of recursive? #84

Open
2 tasks
ProfJanetDavis opened this issue Aug 30, 2019 · 0 comments
Open
2 tasks

Should isEditable() be iterative instead of recursive? #84

ProfJanetDavis opened this issue Aug 30, 2019 · 0 comments
Labels
performance A possible performance issue or enhancement question Further information is requested or a decision must be made

Comments

@ProfJanetDavis
Copy link
Collaborator

Since isEditable() is tail recursive, it could be re-written using a while loop instead of recursion. That would probably be a bit less elegant, but might be a bit more efficient. It would also be a bit of work to do.

Evaluate this from a performance perspective:

  • Is an appreciable part of the total runtime spent in the isEditable() function?
  • If so, is the iterative algorithm appreciably faster than the current, recursive algorithm?

Note the same will apply to the isVisible() function proposed as part of the solution to #49. If isVisible() exists, the same considerations will apply. If both questions about isEditable() above are answered "no", ask the same questions for isVisible().

@ProfJanetDavis ProfJanetDavis added question Further information is requested or a decision must be made performance A possible performance issue or enhancement labels Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A possible performance issue or enhancement question Further information is requested or a decision must be made
Projects
None yet
Development

No branches or pull requests

1 participant