Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save on beautify refuses to fire unless manually done first #59

Closed
Icehunter opened this issue Aug 9, 2014 · 4 comments
Closed

save on beautify refuses to fire unless manually done first #59

Icehunter opened this issue Aug 9, 2014 · 4 comments
Assignees
Labels

Comments

@Icehunter
Copy link
Contributor

Issue:
saving on beautify is on yet when I save it does not beautify unless I used ctrl-alt-b first. This however prevents whitespace from ensuring a blank line at the end of the file.

Installed Packages:

/Users/.../.atom/packages (19)
├── atom-beautify@0.6.1
├── atom-darker-ui@0.27.0
├── autoclose-html@0.8.0
├── autocomplete-paths@0.7.0
├── autocomplete-plus@0.21.0
├── coffee-compile@0.4.0
├── file-icons@1.3.2
├── gist-it@0.5.0
├── git-plus@3.10.1
├── language-ect@0.2.0
├── language-puppet@0.10.0
├── linter@0.5.6
├── linter-jshint@0.0.17
├── merge-conflicts@1.2.4
├── monokai-dark@1.0.0
├── open-in-browser@0.1.0
├── script@2.8.0
├── sublime-tabs@0.4.1
└── turbo-javascript@0.0.5

I'm also using OSX Yosemite. Not sure if that matters but this started happening in last 24 hours and I went through my install history and can't figure out what could have caused it.

Is there any info I could provide?

@Glavin001 Glavin001 added the bug label Aug 9, 2014
@Glavin001 Glavin001 self-assigned this Aug 9, 2014
@Glavin001
Copy link
Owner

At first read it immediately struck me as an issue caused by using activation events (See 4271bfe ). However, if you say it just started happening within the last 24 hours then I am a little surprised.
I will look into this as soon as I can.

The activation events were so that the package would not load until initially called once (like you described), so therefore the load time is faster and offset to the time of the first beautify. However, this would of course mean that observers to events such as the save event would not be created until after that first beautify. So ideally, simply removing the activation event would solve this issue.

@Icehunter
Copy link
Contributor Author

That fixed it. Just removing the package.json item. Thanks!

Personally speaking it doesn't add "too much" startup time. That's me coming over from using webstorm as an IDE though.

"This package added 141ms to startup time."

You've done a great job with this!

@Glavin001
Copy link
Owner

Excellent. Glad to hear it worked!
I will

  • remove activationEvents.

And also in the future be doing some even more major refactoring and performance improvements. I believe I can keep the load time and general performance high while not using activationEvents and providing all of the functionality the users love.

Thanks for your feedback!

@Glavin001
Copy link
Owner

Published v0.6.2 with fix :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants