New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for readonly class #1046
Conversation
@czosel would love your feedback on this approach. |
Hi @genintho - the general approach looks good to me! 👍 |
Not sure why CI is breaking now. Running the typescript command locally show no difference. 🤔 I must be missing something. |
implicit version of tsc and @types/nodes conflict with the global install of typescript done in ci
d2f53c6
to
252d3f3
Compare
@czosel this is ready for review. I had to install I would love an alternative solution, but I already waste a couple of hours on this. |
…nintho-readonly-class
@czosel happy new year! 😄 I did what you asked. We should be good to go. |
@genintho thank you, all the best for you as well! 🎉 LGTM 👍 |
Released in |
Is this approach ok?
According to https://php.watch/versions/8.2/readonly-classes
I know some tests will fail, I am showing this to verify that my approach is ok.