Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary cast: isDoubleQuote incorrect #149

Closed
czosel opened this issue Apr 11, 2018 · 1 comment
Closed

Binary cast: isDoubleQuote incorrect #149

czosel opened this issue Apr 11, 2018 · 1 comment
Assignees
@ichiriac
Labels
AST bug
Milestone
3.0.0 - stable

Comments

@czosel
Copy link
Collaborator

czosel commented Apr 11, 2018

I would expect isDoubleQuote: true here:
image
@czosel czosel mentioned this issue Apr 11, 2018
Closed
@ichiriac ichiriac self-assigned this Apr 11, 2018
@ichiriac ichiriac added this to the 3.0.0 milestone Apr 11, 2018
@ichiriac
Copy link
Member

** Breaking Changes **

Before b"$var" does use a binary node, and the raw encapsed node does not include the b prefix.

From this commit, the binary encapsed nodes are no more into a binary node and the raw property includes the b prefix.

Next I will have to include the unicode property on encapsed nodes also, as explained here : #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ichiriac ichiriac

Labels
AST bug
Projects
None yet
Milestone
3.0.0 - stable
Development

No branches or pull requests
2 participants
@ichiriac @czosel