[bug] invalid ast for const

[alexander-akait]

Input:

const CONSTANT = 'Hello', TEST = 'world';

Output each const as separate item, but should have same ast as for static. I will look how we can fix it.

[ichiriac]

Here some hints because you have multiple parts to change :

You can start here :

php-parser/src/parser/statement.js

Line 64 in eed5703

return this.next().read_const_list();

You may have a location problem with this node

You have to change the way this function works by changing the node instanciation :

php-parser/src/parser/statement.js

Line 105 in eed5703

read_const_list: function() {

You may have to change the signature of the AST node :
https://github.com/glayzzle/php-parser/blob/master/src/ast/constant.js

1. You can use the expression statement with this node as it expects the endOfStatement :
   

   php-parser/src/parser/statement.js

   Line 121 in eed5703

   this.expectEndOfStatement();

Note : every expression waiting an endOfStatement should be wrapped on an expressionstatement node.

2. You may need to create a new ConstantDeclaration node extending the Expression Node, having a list of constant nodes.
   After declaring the new node into its file you have to register it here :

   php-parser/src/ast.js

   Line 341 in eed5703

   [

3. Use the new node into the read_const_list function

[ichiriac]

After you will have to also migrate const keyword from classes :
https://github.com/glayzzle/php-parser/blob/master/src/parser/class.js#L80

In order to do this, you have to create a ClassConstantDeclaration (that replaces the ClassConstant usage) extending the ConstantDeclaration and introducing the visibility flag.