Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8: Attributes support #654

Closed
Wulfheart opened this issue Feb 5, 2021 · 2 comments · Fixed by #918
Closed

PHP8: Attributes support #654

Wulfheart opened this issue Feb 5, 2021 · 2 comments · Fixed by #918

Comments

@Wulfheart
Copy link

#486
@MasonD
Copy link

MasonD commented Dec 9, 2021

Attributes are kinda supported on the php8 branch, but not completely. For example, the following throws an error:

#[Attribute(Attribute::TARGET_PROPERTY | Attribute::TARGET_METHOD)]
class ClassName { }

Error: Bad terminal sequence "|"

@AndreasA AndreasA mentioned this issue Mar 9, 2022
Closed
@MaartenStaa MaartenStaa mentioned this issue Apr 30, 2022
Merged
@czosel
Copy link
Collaborator

czosel commented May 22, 2022

Fixed in 3.1.0-beta.6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix attribute parsing issues MaartenStaa/php-parser
3 participants
@MasonD @czosel @Wulfheart