Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ is an illegal character in external javascript module name #3179

Closed
ofekd opened this issue May 22, 2024 · 1 comment
Closed

@ is an illegal character in external javascript module name #3179

ofekd opened this issue May 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ofekd
Copy link

ofekd commented May 22, 2024

This is needed when importing scoped packages which start with @.

I could open a PR and add @ as a character to the regex, but isn't it better to just allow anything, and leave the resolution to the bundler/runtime?

In Linux, for example, almost any character is a legal filename, and therefore someone somewhere must have a very weirdly-named JS file that they want to use in an @export.

@ofekd ofekd added the bug Something isn't working label May 22, 2024
@lpil
Copy link
Member

lpil commented May 23, 2024

Thank you

@lpil lpil closed this as completed in c9e1889 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants