Mixed optional and keywords arguments in BaseTask

[microstudi]

PR #394 introduced a new argument in BaseTask:

i18n-tasks/lib/i18n/tasks/base_task.rb

Line 42 in 1b9e046

def initialize(config = {}, config_file: nil)

The problem is that uses a keyword argument after an optional argument. This leads to situations where backward compatibility is broken. For instance, this used to work fine:

I18n::Tasks::BaseTask.new(locales: some_locales)

Now it throws an ArgumentError because ruby tryies to allocate the passed arguments as part of the keywords hash.
So now you have to call the method like this, which seems illogical to me:

I18n::Tasks::BaseTask.new({locales: some_locales}, config_file: nil)

This is going to broke some CI tests around. Maybe it would be better to use only one style for the method argument definition?

[glebm]

Yeah, makes sense, let's change it to something like this (PR welcome)

def initialize(config_file: nil, **config)

[microstudi]

will do! thanks