Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL 2.0 #61

Closed
sergeyklay opened this issue Jan 20, 2013 · 12 comments
Closed

ACL 2.0 #61

sergeyklay opened this issue Jan 20, 2013 · 12 comments

Comments

@sergeyklay
Copy link
Contributor

I have some ideas on ACL...
I think I could improve it.
Let me move it in a separate module (may be Gleez ACL) to improve it

@sandeepone
Copy link
Member

Can you explain your ideas if possible?

@sergeyklay
Copy link
Contributor Author

First, I think it is wrong that in the absence of access, triggered exception or throws (403, 404, etc.).
But I think we need to to log such events.
Maybe, if the user is not logged in, it makes sense to redirect the authentication page

@sandeepone
Copy link
Member

Many cases we need to throw 404 or 403 and in few cases we need to redirect to login form if not logged in.

@sergeyklay
Copy link
Contributor Author

In general, the fundamental idea is to add ability a callback method as an argument to ACL::required()

@sandeepone
Copy link
Member

I think we can add ACL::redirect cases where we need redirect to another page or login

@sergeyklay
Copy link
Contributor Author

I looked similar implementation in Zend and Symfony and I found that we could borrow a something

@sergeyklay
Copy link
Contributor Author

Maybe worth paying attention to the ready-made solutions for similar problems:

@sergeyklay
Copy link
Contributor Author

Hi all!

@sandeepone

I have some ideas about ACL 2.0 that you can look at this url: https://gist.github.com/sergeyklay/5075595

Here's one way how we can use this: https://gist.github.com/sergeyklay/5075608
But this is not the only change in the ACL class, and this is beta version

I seriously reworked the code and add new methods.
And I'm interested in your opinion

@dishuostec

If you have anything to add - it would be good

Best regards,

@sergeyklay sergeyklay mentioned this issue Mar 7, 2013
@sergeyklay
Copy link
Contributor Author

#128

@sergeyklay
Copy link
Contributor Author

also see:
68b60b7
5da99fe
a4b8b03
0abe2a3
d35b326

@sandeepone
Copy link
Member

Sorry, I didn't follow this issue, but we've covered most of the things.

@sergeyklay
Copy link
Contributor Author

yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants