Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Release 0.2 #30

Open
4 tasks
glemmaPaul opened this issue May 27, 2016 · 5 comments
Open
4 tasks

Release 0.2 #30

glemmaPaul opened this issue May 27, 2016 · 5 comments
Labels

Comments

@glemmaPaul
Copy link
Owner

Changes to be made:

@wen96
Copy link

wen96 commented Aug 24, 2016

Are you planning to do it soon? Do you need help?

@glemmaPaul
Copy link
Owner Author

@wen96 I would really appreciate help 🙂. Is there anything in particular you would like to work on?

@wen96
Copy link

wen96 commented Aug 29, 2016

I need to return slugs instead of names for the project thaw I'm working on. Issue #29 could be enough to me, but I agree with you that returning entire objects could "break" the tags meaning. So, main-while some solution is provided, I've forked and implemented a quick patch to allow define which field do you want to get from Tag model. Something like:

tags = TagListSerializerField(tag_field='slug')

So, I can implement #29 or I can extend my current solution to support tag_field. I'm OK to provide a PR with any of them.

(The tag_field feature is almost a new issue I can open a new one or add further discussion to #29 if you want)

@glemmaPaul
Copy link
Owner Author

@wen96 So what is the scenario you encounter you needed tag_field?

@wen96
Copy link

wen96 commented Aug 31, 2016

Slugs are invariable even if you have more than platform. Imagine that you have two services A and B. Both contains models tagged using Taggit library. Then the service B wants to check if some data on service A contains certainly tags used on service B. So, the only way to check that is to use slugs because it will be the same at both platforms, names not.

That is because I said #29 is enough, it provide both fields.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants