Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1.1.4 update seems to be breaking mocha dependency #82

Closed
bal360 opened this issue Sep 30, 2021 · 8 comments
Closed

Patch 1.1.4 update seems to be breaking mocha dependency #82

bal360 opened this issue Sep 30, 2021 · 8 comments

Comments

@bal360
Copy link

bal360 commented Sep 30, 2021

Apologies ahead of time if this is a mocha issue, rather than an issue with mocha-multi, but it appears the recent update to 1.1.4 is now breaking with a range of mocha versions.

Dependencies:

"dependencies": {
    "@babel/core": "^7.4.5",
    "@babel/preset-env": "^7.4.5",
    "chai": "^4.2.0",
    "jsdom": "^9.0",
    "mocha": "5.2.0",
    "mocha-jsdom": "~1.1.0",
    "mocha-multi": "^1.0.1",
    "sinon": "^7.3.1"
  }

Error:

bal@Blakes-MacBook-Pro-2 phase-0-intro-to-js-2-looping-code-along % npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: js-looping-and-iteration-looping-code-along@0.1.0
npm ERR! Found: mocha@5.2.0
npm ERR! node_modules/mocha
npm ERR!   mocha@"5.2.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer mocha@"2.2.0-7.0.0 || ^9.0.0" from mocha-multi@1.1.4
npm ERR! node_modules/mocha-multi
npm ERR!   mocha-multi@"^1.0.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/bal/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/bal/.npm/_logs/2021-09-30T15_00_58_403Z-debug.log
@glenjamin
Copy link
Owner

glenjamin commented Sep 30, 2021

oof, it seems like #79 might be using some semver syntax that doesn't match? otherwise 5.2.0 should match 2.2.0-7.0.0?

I'll deprecate 1.1.4 for now until we know what's up

EDIT: ok, 1.1.4 is marked deprecated for the moment - I believe this should stop npm offering it as latest.

@bal360
Copy link
Author

bal360 commented Sep 30, 2021

Thank you for the update. Unfortunately, I just tried npm install again and it's still grabbing 1.1.4 and breaking on install.

@glenjamin
Copy link
Owner

Ah ok, I've now also manually set the latest tag to be 1.1.3 - that should be better?

@MarcCelani-at
Copy link
Contributor

doh, sorry about this folks

@ihollander
Copy link

I think I have a fix in #83 - it looks like a small syntax issue with setting up a range for 2.2.0 - 7.0.0.

@glenjamin
Copy link
Owner

Ok, this should be fixed in 1.1.5 now.

Thanks for the quick responses everyone!

@ihollander
Copy link

Looks good on my end, thanks for the speedy fix!

@bal360
Copy link
Author

bal360 commented Sep 30, 2021

Working for me too! Thanks to everyone for being so prompt!

@bal360 bal360 closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants