Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass client initialisation in a DOM-less environment. #63

Merged
merged 1 commit into from
Jan 24, 2016

Conversation

richardgoater
Copy link
Contributor

Hello, really appreciate this project, thank you. I've added a few conditionals preventing the middleware from breaking the build when the DOM isn't present, in my case when using static-site-generator-webpack-plugin. I've also removed some duplicate keys from the .eslint file, which gave me a few errors in Atom. Let me know if you'd like me to change anything,

@glenjamin glenjamin merged commit 2ec55b6 into webpack-contrib:master Jan 24, 2016
glenjamin added a commit that referenced this pull request Jan 24, 2016
Bypass client initialisation in a DOM-less environment.
@glenjamin
Copy link
Collaborator

I've just merged this with some slight tweaks and some unit tests.

I also moved the document check, let me know if this causes issues.

Released as 2.6.1

@richardgoater
Copy link
Contributor Author

Thanks for taking the time to look at this @glenjamin. I'm afraid the new document check does indeed cause issues for me, I think document is still accessed without a check on this line: https://github.com/glenjamin/webpack-hot-middleware/blob/master/client-overlay.js#L3.

@glenjamin
Copy link
Collaborator

Whoops, that was sloppy 2.6.2 released

@richardgoater
Copy link
Contributor Author

Not a problem sir, thanks very much for sorting it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants