Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even better overlay styling #82

Merged
merged 3 commits into from
Mar 1, 2016
Merged

Conversation

yyx990803
Copy link
Contributor

  • Using ansi-html instead of ansi-to-html-umd, which gives us the ability to customize the color output instead of hard-coded colors; (also avoid having to do the umd wrap)
  • Adjusted color scheme, fonts, spacing, and added problem type labels. Also added slight opacity to background so that it's more obvious to the user that the current app state is being preserved.
  • Moved the ANSI -> HTML conversion logic into client-overlay.js instead of client.js. This way custom overlay implementations receive raw ANSI strings instead of pre-converted HTML so that they have more flexibility in how to display the messages.

Before

screen shot 2016-03-01 at 1 21 13 pm

After

screen shot 2016-03-01 at 1 21 01 pm

@yyx990803 yyx990803 changed the title move ansi-to-html conversion into client-overlay.js Even better overlay styling Mar 1, 2016
@yyx990803
Copy link
Contributor Author

Ah, just found out ansi-html doesn't handle HTML entity escape. Looking into that.

@glenjamin glenjamin merged commit 9cb6593 into webpack-contrib:master Mar 1, 2016
glenjamin added a commit that referenced this pull request Mar 1, 2016
Even better overlay styling
@glenjamin
Copy link
Collaborator

Great work, that looks ace!

@rossipedia
Copy link
Contributor

Neat! Much better than my original impl, looks good 👍

@glenjamin
Copy link
Collaborator

Released as 2.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants