Remvoing REM use from "lineHeight" property #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REMs are units relative to a viewport's font size, so if it's set to a small one (like 8px) overlay would have lines jumping over each other
|
Probably change it here as well (to em or px) https://github.com/glenjamin/webpack-hot-middleware/pull/83/files#diff-1a1bba6c8b5211b37d2d1e57b2f90304L54 |
|
@yyx990803 not sure what do you mean, to me that link points to my change. |
|
@Restuta sorry, obviously line numbers don't work in diffs: https://github.com/Restuta/webpack-hot-middleware/blob/patch-1/client-overlay.js#L54 |
|
@yyx990803 changed to "px" |
glenjamin
added a commit
that referenced
this pull request
Mar 2, 2016
Remvoing REM use from "lineHeight" property
|
Released as |
|
yay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REMs are units relative to a viewport's font size, so if it's set to a small one (like 8px) overlay would have lines jumping over each other