Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseUrl promise not working #19

Closed
janober opened this issue Feb 22, 2015 · 2 comments
Closed

parseUrl promise not working #19

janober opened this issue Feb 22, 2015 · 2 comments

Comments

@janober
Copy link

janober commented Feb 22, 2015

Just wanted to try it out and did run the parseUrl-promise example. However it did always error with "TypeError: Cannot call method 'then' of undefined"

After checking the source code I saw that the "parseUrl" does not return a promise. The return is actually simply commented out (5546247). Is there a reason for that or did that happen by accident? If not the example should probably get removed.

@glennjones
Copy link
Owner

Hi took me ages to get around to this, but codebase has been updated. New lib is based on some work for Mozilla so will now hopefully be kept update.

It has promises provide by using Bluebird, I have also built tests for all the promise interface so hopefully it will not break again without me noticing.

@janober
Copy link
Author

janober commented Sep 8, 2015

Great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants