Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dotenv #33

Open
glennreyes opened this issue Nov 5, 2018 · 2 comments
Open

Support Dotenv #33

glennreyes opened this issue Nov 5, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@glennreyes
Copy link
Owner

Similar to CRA, I've found it useful to have that supported out of the box.

@glennreyes glennreyes added the help wanted Extra attention is needed label Nov 5, 2018
@manpenaloza
Copy link

manpenaloza commented Nov 5, 2018

would like to deal with that if ok (?).

just some questions upfront:

  • what's the main goal of this to be considered when implementing (especially regarding a cleaner code base)?
  • is it ok to use oss packages like https://github.com/motdotla/dotenv to solve this?

@glennreyes
Copy link
Owner Author

I'd propose https://webpack.js.org/plugins/environment-plugin/#dotenvplugin. Ideally .env works well together with webpack.Environmentplugin (when set in the graphpack.config.js)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants