-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests would timeout under ReScript v11.0.0-rc.4 with uncurried: false
#119
Comments
Not sure if this can/should be solved here. Any suggestions @zth, @cristianoc? |
When I change this line Line 138 in 817581e
to @val external _test: (string, (. unit) => Js.undefined<unit>) => unit = "test" and adapt the callsites to using (. ()) as well, it works! |
I applied the changes @fhammerschmidt suggested to |
Does it also work seamlessly with v10? |
I just hit this, and yes That suggests |
It's a breaking change in 10 in that it requires functions to be applied with |
Should be fixed in 0.11. Let me know if there are any issues. |
Just change Rescript to v11.0.0-rc.4 and add
uncurried: false
tobsconfig.json
,npm test
will fail with timeout.It seems like Rescript v11 adds a
param
to the callback oftest
function which causes the timeout.with
uncurried: false
inbsconfig.json
without
uncurried: fase
inbsconfig.json
(ie: default uncurried mode)Here is the repo to demonstrate:
https://github.com/dsiu/rescript-jest/tree/rescript-v11-curried-mode
The text was updated successfully, but these errors were encountered: