Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to concatenate local 'icon' when using Hyper theme with default configs #247

Closed
karunsiri opened this issue Jan 26, 2023 · 2 comments

Comments

@karunsiri
Copy link

Describe the bug
Just updated the plugin to this commit 1af4b73 with provided example configurations

db.setup({
  theme = 'hyper',
  config = {
    shortcut = {
      { desc = ' Update', group = 'DashboardShortCut', action = 'PackerSync', key = 'u' },
    },
  },
})

When opening a new nvim instance by executing

nvim

The error occurs
dashboard no mru list

Raw log for future reference

hyper.lua:123: attempt to concatena
te local 'icon' (a nil value)
stack traceback:
        dashboard-nvim/lua/dashboard/theme/hyper.lua:123: in function 'mru_list'
        dashboard-nvim/lua/dashboard/theme/hyper.lua:171: in function 'gen_center'
        dashboard-nvim/lua/dashboard/theme/hyper.lua:272: in function 'callback'
       dashboard-nvim/lua/dashboard/theme/hyper.lua:100: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

To Reproduce
Steps to reproduce the behavior:

  1. Set up dashboard-nvim using Hyper theme with example configuration
  2. Open new instance of nvim

Expected behavior
Nvim starts with dashboard shown without errors

Screenshots
dashboard no mru list

@karunsiri
Copy link
Author

Though I find these lines and not sure if it's the cause of this or not. https://github.com/glepnir/dashboard-nvim/blob/master/lua/dashboard/utils.lua#L87-L93

I do have nvim-web-devicons installed, but this is the first time I run the new dashboard so my MRU list would be nil?
I don't know lua so please have a look.

Thank you!

@glepnir
Copy link
Member

glepnir commented Jan 26, 2023

I do have nvim-web-devicons installed, but this is the first time I run the new dashboard so my MRU list would be nil?

nope it will read v:old . if it is empty I will fill a empty message

ThePolishHussar added a commit to ThePolishHussar/dashboard-nvim that referenced this issue Jan 26, 2023
improper way of getting deps via packer. caused issue nvimdev#247
glepnir pushed a commit that referenced this issue Jan 26, 2023
improper way of getting deps via packer. caused issue #247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants