Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation on exclude #33

Closed
tiloc opened this issue Mar 20, 2021 · 4 comments
Closed

Better documentation on exclude #33

tiloc opened this issue Mar 20, 2021 · 4 comments

Comments

@tiloc
Copy link
Contributor

tiloc commented Mar 20, 2021

I am trying to exclude any Flutter SDK packages from the output. I have tried a lot of variations:
--exclude=^flutter.*
--exclude=flutter.*
--exclude=StatefulWidget
--exclude=.*StatefulWidget

none of these seem to have any effect. I am looking for better documentation on such a use-case and maybe a --verbose option for dcdg that prints out whether it believes something is a match. It is unclear to me whether the package names, such as flutter:: are part of the class name that needs to match.

I have also attempted the --exported-only option as an alternative, but that leads to broken output with numerous repeating fields.

@glesica
Copy link
Owner

glesica commented Mar 20, 2021

Most of the exclude stuff hasn't yet been implemented. Take a look at #1 for status. Right now it only works on class names. I'll take a look at the --exported-only, there might be a bug there.

@glesica
Copy link
Owner

glesica commented Mar 20, 2021

What's broken about the output when using --exported-only?

@tiloc
Copy link
Contributor Author

tiloc commented Mar 20, 2021

I get to see the same field name several times.
I have spent the past 2 hours or so familiarising myself with the package and adding some better exclude functionality plus a new "--verbose" parameter. Will show you my PR probably later today, currently making sure the tests run.

@glesica
Copy link
Owner

glesica commented Mar 22, 2021

Can we close this? It seems as though #1 captures the rest of the issues here that weren't fixed by #34.

@tiloc tiloc closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants