Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for laravel 9 #1

Merged
merged 3 commits into from Jan 22, 2022
Merged

Prepare for laravel 9 #1

merged 3 commits into from Jan 22, 2022

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Jan 20, 2022

@Jubeki
Copy link
Contributor Author

Jubeki commented Jan 22, 2022

@inxilpro I can make this package Laravel 9 compatible if I remove BrainMaestro/composer-git-hooks.
Since you already have a workflow for the style check in place you don't need to check before committing or pushing I think.

@inxilpro
Copy link
Contributor

Hm. Yeah, I guess that's fine. Go for it!

@Jubeki Jubeki marked this pull request as ready for review January 22, 2022 17:04
@Jubeki
Copy link
Contributor Author

Jubeki commented Jan 22, 2022

Okay, I removed the dependency.
Tests passed on my repository.

@Jubeki
Copy link
Contributor Author

Jubeki commented Jan 22, 2022

I just tested my branch on a Laravel 9 Project and everything seems to be working fine.

@inxilpro inxilpro merged commit 84233d8 into glhd:main Jan 22, 2022
@inxilpro
Copy link
Contributor

Thanks!

@Jubeki Jubeki deleted the prepare-for-laravel-9 branch January 22, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jubeki @inxilpro