Wrapperless cell editor

[pzcfg]

I'm building a custom cell editor using the provideEditor attribute, but it seems that this enforces that the editor gets put inside a DataGridOverlayEditorStyle and clip-region div which adds its own border, border radius and styles input and textarea elements.

glide-data-grid/packages/core/src/data-grid-overlay-editor/data-grid-overlay-editor.tsx

Lines 108 to 117 in 6b0a04f

	const portal = createPortal(
	<ClickOutsideContainer className={className} onClickOutside={onClickOutside}>
	<DataGridOverlayEditorStyle targetRect={target} pad={pad}>
	<div className="clip-region" onKeyDown={CustomEditor === undefined ? undefined : onKeyDown}>
	{editor}
	</div>
	</DataGridOverlayEditorStyle>
	</ClickOutsideContainer>,
	portalElement
	);

Would it be possible to support a version of provideEditor that handles its own borders to allow for more flexibility?

I see that I can add a disablePadding property to remove the padding, but it would be great if there was another attribute that could remove some of this other styling too.

glide-data-grid/packages/core/src/data-grid-overlay-editor/data-grid-overlay-editor.tsx

Lines 71 to 82 in 6b0a04f

	let pad = true;
	let editor: React.ReactNode;
	if (CustomEditor !== undefined) {
	pad = CustomEditor.disablePadding !== true;
	editor = (
	<CustomEditor
	isHighlighted={highlight}
	onChange={setTempValue}
	value={targetValue}
	onFinishedEditing={onClickOutside}
	/>
	);

[bjgrosse]

Another vote for this!

[jassmith]

Yes this can be added, we cant get rid of the wrapper entirely but we can unstyle it.

[pzcfg]

That works for me!

One other issue I've been running into is needing more editor space below the cell. Currently there's a max-height: calc(100vh - ${p => p.targetRect.y + 10}px) that's preventing that from growing. I can use the experimental.paddingBottom to help alleviate this if the user manually scrolls down, but if they haven't, it only scrolls to the bottom of the cell itself and then keeps it clipped. Do you have a suggestion for working around that?

[jassmith]

What do you want that to do? Currently it stops the cell editor going off screen

[pzcfg]

I think in the ideal world, if the child wants to grow, it would scroll the table so that the top of the editor still lines up with the cell but the bottom of the editor isn't cut off, but that seems overly complicated. Maybe the editor could specify an anticipated max-height and the table will try to scroll that extra amount when you go to edit?

For now I think I can work around it using paddingBottom and scrollTo with paddingY getting added here #139 (comment)

I'll give some more thought on what would be best here

[jassmith]

Fixed in 3.3.0