Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API inconsistencies #8

Closed
6 tasks done
schani opened this issue Dec 27, 2020 · 0 comments · Fixed by #7
Closed
6 tasks done

API inconsistencies #8

schani opened this issue Dec 27, 2020 · 0 comments · Fixed by #7

Comments

@schani
Copy link
Member

schani commented Dec 27, 2020

  • onVisibleRowsChanged is badly named. It affects columns, too. Maybe onVisibleRegionChanged? - yes
  • onColumnMoved takes a column index, but onColumnResized takes a GridColumn. - that's fine for now
  • We use an array for X/Y coordinates, a Rectangle object for rectangles, and drawCustomCell takes x/y/width/height as four separate arguments. - make drawCustomCell take a Rectangle
  • EditableGridCell should have a common newValue property #5 - make the underlying data always present as data, with displayData being there sometimes
  • allowInsertRow and onRowInserted should probably be called "add" or "append" instead of "insert" - showTrailingBlankRow and onRowAppended
  • getCellsForSelection is passed a GridSelection, but only its rectangle is needed - fix it
@schani schani changed the title onVisibleRowsChanged is badly names onVisibleRowsChanged is badly named Dec 27, 2020
@schani schani changed the title onVisibleRowsChanged is badly named API inconsistencies Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant