Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle toplevel properly #22

Closed
3 tasks done
schani opened this issue Jul 22, 2017 · 1 comment
Closed
3 tasks done

Handle toplevel properly #22

schani opened this issue Jul 22, 2017 · 1 comment

Comments

@schani
Copy link
Member

schani commented Jul 22, 2017

  • TopLevel class should come first
  • don't test for class name TopLevel
  • Handle non-class JSON (we don't even generate a TopLevel class for that now)
@schani schani marked this as a duplicate of #24 Jul 22, 2017
@schani
Copy link
Member Author

schani commented Jul 23, 2017

fromJSON is now in Converter, which kinda solves all these points, albeit not quite satisfactorily.

@schani schani closed this as completed Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant